-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user limits #22479
Merged
Merged
Add user limits #22479
+1,220
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cbb4d23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
br41nslug
reviewed
May 28, 2024
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
paescuj
requested changes
Jun 3, 2024
2chiefk
approved these changes
Jun 3, 2024
2chiefk
approved these changes
Jun 3, 2024
paescuj
reviewed
Jun 3, 2024
paescuj
previously requested changes
Jun 3, 2024
This comment was marked as resolved.
This comment was marked as resolved.
2chiefk
approved these changes
Jun 4, 2024
2chiefk
approved these changes
Jun 4, 2024
paescuj
reviewed
Jun 4, 2024
* adressing existing users issue * migrated changes from pascal * only check the role for active users * only count active users * updated incorrect if * default to count zero * Undid abstraction to separate function * fixed updating through user counting error * prettier * simplified fallback query * prettier * Added try catch to be safee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
Potential Risks / Drawbacks
Review Notes / Questions
Implements the limits mentioned in issue #21981 for Public Registration #22125