Break circular dependency between gstreamer and libnice
#171902
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new formula
carlocab
added
the
CI-no-fail-fast
carlocab
force-pushed
the
gstreamer-libnice
branch
from
cc60a20
to
b692485
Compare
carlocab
commented
May 16, 2024
Formula/lib/libnice-gstreamer.rb
Outdated
Comment on lines
34
to
43
| test do | ||
| # Based on https://github.com/libnice/libnice/blob/HEAD/examples/simple-example.c | ||
| (testpath/"test.c").write <<~EOS | ||
| #include <agent.h> | ||
| int main(int argc, char *argv[]) { | ||
| NiceAgent *agent; | ||
| GMainLoop *gloop; | ||
| gloop = g_main_loop_new(NULL, FALSE); | ||
| // Create the nice agent | ||
| agent = nice_agent_new(g_main_loop_get_context (gloop), | ||
| NICE_COMPATIBILITY_RFC5245); | ||
| if (agent == NULL) | ||
| g_error("Failed to create agent"); | ||
|
|
||
| g_main_loop_unref(gloop); | ||
| g_object_unref(agent); | ||
| return 0; | ||
| } | ||
| EOS | ||
|
|
||
| pkg_config_cflags = shell_output("pkg-config --cflags --libs nice").chomp.split | ||
| system ENV.cc, "test.c", *pkg_config_cflags, "-o", "test" | ||
| system "./test" | ||
| end |
There was a problem hiding this comment.
Probably need a new test.
There was a problem hiding this comment.
Checking whether gst-inspect-1.0 --exists nicesrc returns 0 is probably a good test.
There was a problem hiding this comment.
Presumably I would need to set some environment variables for this to work, since GStreamer wants to find all the plugins in its own prefix?
There was a problem hiding this comment.
Hm, so this should actually be built as part of the gstreamer monorepo then. Let me cook up a patch to do that.
There was a problem hiding this comment.
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6871
So, instead of creating a new libnice-gstreamer.rb formula, you'd patch gstreamer.rb
carlocab
force-pushed
the
gstreamer-libnice
branch
from
b692485
to
5aa831f
Compare
carlocab
added
CI-linux-self-hosted
carlocab
force-pushed
the
gstreamer-libnice
branch
2 times, most recently
from
2f8ee2a
to
d81b906
Compare
github-actions
bot
added
the
automerge-skip
carlocab
removed
the
automerge-skip
carlocab
force-pushed
the
gstreamer-libnice
branch
from
d81b906
to
493b545
Compare
github-actions
bot
added
the
automerge-skip
carlocab
added
CI-no-fail-fast
carlocab
force-pushed
the
gstreamer-libnice
branch
from
493b545
to
c031af2
Compare
github-actions
bot
added
the
automerge-skip
Also, add dependencies that are linked indirectly.
This will allow us to build `gstreamer` with `libnice` as a dependency. Also, add `gettext` dependency on macOS, since this has indirect linkage to it.
carlocab
force-pushed
the
gstreamer-libnice
branch
from
c031af2
to
788928e
Compare
This installs only the GStreamer plugin for libnice.
carlocab
force-pushed
the
gstreamer-libnice
branch
from
788928e
to
547e259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?See Homebrew/discussions#3740, in particular, https://github.com/orgs/Homebrew/discussions/3740#discussioncomment-8566223.
gstreamerplugin