PortX 2.2.6 #174082
Merged
PortX 2.2.6 #174082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
approved these changes
May 17, 2024
|
/rebase |
samford
reviewed
May 17, 2024
There was a problem hiding this comment.
The livecheck block makes sense to me. The latest dmg file is linked from the download page and the hash in the URL (0ac7ea20) is the same in the available archive.org snapshots from 2023 (albeit, there are only two to compare). Hopefully the hash doesn't change with website updates but we can address that if/when it happens.
I'll leave overall review to our cask maintainers but it looks fine to me.
bevanjkay
reviewed
May 17, 2024
miccal
approved these changes
May 17, 2024
bevanjkay
approved these changes
May 17, 2024
|
This is fine for me, but I'd like to avoid @NetSarangComputer it would be very helpful to have a method to get version information without needing to download 2 * 100mb files. Please consider publishing that information. Thanks |
krehel
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.